fix(cache): Update the mtime when it is 1h out of date #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code used to update the mtime wasn't actually updating the mtime as nothing was ever written to the file, it was only opened. This pulls in a new library which seems to do a better job at this. There is now an explicit unit test for this, before this was tried to be covered by an extra iteration in an integration test but this was occasionlly flaky and did not take into account the mtime needed to be out of date for more than an hour.
Swatinem
approved these changes
Feb 18, 2021
loewenheim
approved these changes
Feb 18, 2021
untitaker
approved these changes
Feb 18, 2021
jan-auer
approved these changes
Feb 19, 2021
Co-authored-by: Jan Michael Auer <mail@jauer.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code used to update the mtime wasn't actually updating the mtime
as nothing was ever written to the file, it was only opened. This
pulls in a new library which seems to do a better job at this.
There is now an explicit unit test for this, before this was tried to
be covered by an extra iteration in an integration test but this was
occasionlly flaky and did not take into account the mtime needed to be
out of date for more than an hour.