feat: Implement new Symbolication Metrics #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This collects metrics on the number of scanned or unsymbolicated frames, those referencing unmapped modules, and stack traces that do not end in well known thread bases or contain any of the mentioned bad frames.
loewenheim
approved these changes
May 3, 2021
flub
reviewed
May 3, 2021
flub
reviewed
May 3, 2021
flub
reviewed
May 3, 2021
flub
approved these changes
May 7, 2021
| /// Stacktrace related Metrics | ||
| /// | ||
| /// This gives some metrics about the quality of the stack traces included | ||
| /// in a symbolication request. See the individual members for more information. |
There was a problem hiding this comment.
maybe say these are all supposed to be recorded as histograms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This collects metrics on the number of scanned or unsymbolicated frames,
those referencing unmapped modules, and stack traces that do not end in
well known thread bases or contain any of the mentioned bad frames.