fix(symsorter): Don't emit files with empty debug identifiers #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Files that symsorter was unable to generate a valid, nonempty debug identifier (i.e. 000...000) for were being written to disk as if they were successfully parsed and sorted. Chances are if the debug identifier is empty, then the debug info is unusable.
jan-auer
approved these changes
Jun 17, 2021
| } else { | ||
| obj.code_id().as_ref().unwrap().as_str().to_string() | ||
| Ok(obj.code_id().as_ref().unwrap().as_str().to_string()) |
There was a problem hiding this comment.
Could you check that this identifier is non-empty, too?
There was a problem hiding this comment.
Good catch, this also tripped me up as well when I was working on this: L30 checks this (|| obj.code_id().is_none()) and enters the debug ID block if .code_id() is empty.
I was thinking of ways to make it more obvious that this else block runs with a non-empty code_id, but anything that came to mind felt like an overcomplication. For example, a match block was one of my ideas:
match (obj.file_format(), obj.code_id()) {
(Pe, _)
| (_, None) => use debug_id,
(_, _) => use code
}Thoughts, opinions?
There was a problem hiding this comment.
Heh, you know our code better than we do. And in fact, code_id can also never be empty since it always returns None instead. This is good to go then 👍
Swatinem
approved these changes
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files that symsorter was unable to generate a valid, nonempty debug identifier (i.e. 000...000) for were being written to disk as if they were successfully parsed and sorted. Chances are if the debug identifier is empty, then the debug info is unusable. Not emitting these saves some manual cleanup work on the user's end since they don't have to prune these directories.
Related: #465