Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make timeout for downloading configurable #482

Merged
merged 4 commits into from
Jul 6, 2021

Conversation

loewenheim
Copy link
Contributor

This addresses NATIVE-57.

@loewenheim loewenheim requested a review from a team July 6, 2021 09:11
Copy link
Contributor

@flub flub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update docs/index.md with this new option?

@loewenheim
Copy link
Contributor Author

I see that the configuration already includes options for cache timeouts; should I bring download_timeout in line with those by using Duration and humantime_serde?

@loewenheim loewenheim merged commit 7cf7265 into master Jul 6, 2021
@loewenheim loewenheim deleted the feat/download-timeout branch July 6, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants