feat(metrics): Add option to send hostname with every metric #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swatinem
approved these changes
Aug 2, 2021
|
Incidentally, is there a way to test this? Would it even make sense to do so? |
|
the way to test these metrics things would be to set up a local docker image will all the relevant servers in there, which is a bit of a pain in the rear. |
flub
reviewed
Aug 3, 2021
Comment on lines
+9
to
+10
| type Hostname = String; | ||
| type HostnameTag = String; |
There was a problem hiding this comment.
i'm curious why you chose aliases rather than newtypes?
There was a problem hiding this comment.
I just wanted it to be clear which string is which in the definition of MetricsClient. I don't think a newtype would provide any extra safety in this situation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an adaptation of https://github.com/getsentry/relay/pull/625/files. This is intended to address https://getsentry.atlassian.net/browse/NATIVE-129.