build(ci): Publish MacOS universal binaries to github releases #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkotsopoulossc
changed the title
bkotsopoulossc
changed the title
Swatinem
approved these changes
Oct 13, 2021
There was a problem hiding this comment.
I forgot to mention this in the first review.
This also needs to update the filenames here:
Lines 31 to 35 in e67a0c1
That is our release automation that uploads those built files to github releases, etc.
|
Thanks! |
|
@Swatinem any word on when the next release will be cut? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #565. This now builds universal binaries and uploads to github releases. This is done in one job in the github workflow, with builds for each architecture running serially. Currently it doesn't seem like there is support in the rust build system to build a single multi-arch MacOS binary in one swoop, so this approach is to build each arch separately, and use
lipoto combine them.PTAL @jan-auer @Swatinem