ref: Forward CacheItemRequest::compute to async fns #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactors the code, pulling as much of the actual computation out into an async fn.
flub
approved these changes
Jan 14, 2022
| /// This is the actual implementation of [`CacheItemRequest::compute`] for | ||
| /// [`FetchFileMetaRequest`] but outside of the trait so it can be written as async/await | ||
| /// code. | ||
| async fn compute_file_meta(self, path: PathBuf) -> Result<CacheStatus, ObjectError> { |
There was a problem hiding this comment.
this version is much nicer than some of the others because of the self arg which means it doesn't need a really long arg list. I guess doing this for the others is too much refactoring (probably not all selfs are clonable)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the code, pulling as much of the actual computation out into an async fn.
Moves some refactors out of #628 and this should in the end help with tokio-rs/tracing#1831
#skip-changelog ffs