Google App Default Credentials Unusable #1155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ajvb Can you merge this |
Closed
hiddeco
reviewed
Jul 3, 2023
Comment on lines
+241
to
247
| defaultCredentials, wasSet := os.LookupEnv(SopsGoogleCredentialsEnv) | ||
| if !wasSet { | ||
| return nil, nil | ||
| } else if _, err := os.Stat(defaultCredentials); err == nil { | ||
| return os.ReadFile(defaultCredentials) | ||
| } | ||
| return []byte(defaultCredentials), nil |
There was a problem hiding this comment.
Suggested change
| defaultCredentials, wasSet := os.LookupEnv(SopsGoogleCredentialsEnv) | |
| if !wasSet { | |
| return nil, nil | |
| } else if _, err := os.Stat(defaultCredentials); err == nil { | |
| return os.ReadFile(defaultCredentials) | |
| } | |
| return []byte(defaultCredentials), nil | |
| if defaultCredentials, ok := os.LookupEnv(SopsGoogleCredentialsEnv); ok { | |
| if _, err := os.Stat(defaultCredentials); err == nil { | |
| return os.ReadFile(defaultCredentials) | |
| } | |
| return []byte(defaultCredentials), nil | |
| } | |
| return nil, nil |
Seems more Go idiomatic.
|
Thank you for your contribution! 🙇 In addition to my review comment, it would be great if you could rebase this and sign-off your commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1151, which broke using app default credentials (and relying on workload identity on GCP hosts), by assuming that GOOGLE_CREDENTIALS would always contain a valid value.