Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic tests for exec-env and exec-file #1396

Merged
merged 1 commit into from
Feb 10, 2024

Conversation

felixfontein
Copy link
Contributor

@felixfontein felixfontein commented Dec 29, 2023

Contains a rebased version of #1390.

@felixfontein
Copy link
Contributor Author

@getsops/maintainers I'm really confused. If I run the tests locally, even with exactly the same sops binary that is used in CI, the tests pass. But in CI they fail. I can really see no reason why they should fail. (Failing means that #784 is already fixed.) Does anyone of you have an idea what's going wrong here?

Signed-off-by: Felix Fontein <felix@fontein.de>
@felixfontein felixfontein marked this pull request as ready for review February 9, 2024 21:47
@felixfontein
Copy link
Contributor Author

Looks like GH's Ubuntu image has a funny /bin/sh. With /bin/bash the behavior is a lot more uniform. Anyway, the test now passes 🎉

@felixfontein felixfontein requested a review from a team February 9, 2024 21:48
@felixfontein felixfontein merged commit 3f712e1 into getsops:main Feb 10, 2024
9 checks passed
@felixfontein felixfontein deleted the exec-tests branch February 10, 2024 09:37
@felixfontein
Copy link
Contributor Author

@onedr0p thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants