Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a constant for the 'sops' metadata key #1398

Merged
merged 2 commits into from
Dec 29, 2023
Merged

Create a constant for the 'sops' metadata key #1398

merged 2 commits into from
Dec 29, 2023

Conversation

felixfontein
Copy link
Contributor

@felixfontein
Create a constant for the 'sops' metadata key.
618b60e 
Signed-off-by: Felix Fontein <felix@fontein.de>
@felixfontein felixfontein mentioned this pull request Dec 29, 2023
Merged
@devstein devstein requested a review from a team December 29, 2023 22:10
devstein
devstein approved these changes Dec 29, 2023
View reviewed changes
Copy link
Contributor

@devstein devstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick work 🚀

One non-blocking golint nit

stores/stores.go Outdated Show resolved Hide resolved
@felixfontein @devstein
Improve comment.
00de085 
Co-authored-by: Devin Stein <devstein@alumni.upenn.edu>
Signed-off-by: Felix Fontein <felix@fontein.de>
@felixfontein felixfontein merged commit 0bceaf4 into getsops:main Dec 29, 2023
9 checks passed
@felixfontein felixfontein deleted the sops-constant branch December 29, 2023 22:40
@felixfontein
Copy link
Contributor Author

@hiddeco @devstein thanks for reviewing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiddeco hiddeco hiddeco approved these changes

@devstein devstein devstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixfontein @devstein @hiddeco