GitHub Actions linter for Rust formatting #1604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duthils
force-pushed
the
gh-actions-linters
branch
from
5a3d9d3
to
4b58b10
Compare
|
Rust is already available on Github runners in version 1.80.1, but I guess we want to keep the same version as is used for running the tests. Thanks for the suggestion! |
Signed-off-by: Sebastien Duthil <duthils@duthils.net>
Signed-off-by: Sebastien Duthil <duthils@duthils.net>
Co-authored-by: Felix Fontein <felix@fontein.de> Signed-off-by: duthils <duthils@duthils.net>
duthils
force-pushed
the
gh-actions-linters
branch
from
4479665
to
6475dae
Compare
Yep; also having a controlled environment is generally a good idea :) Then we can decide which Rust version to use, instead of having to use the version provided by the GHA image. |
felixfontein
approved these changes
Sep 12, 2024
|
@duthils @shikharvashistha thanks for your contribution! |
This was referenced Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes the changes from #1403 and applies them in a dedicated CI workflow.
Fixes #1390