Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for decoding JSON arrays of arrays #642

Merged
merged 1 commit into from
Mar 20, 2020

Conversation

nilium
Copy link
Contributor

@nilium nilium commented Mar 9, 2020

Add support for decoding JSON arrays of arrays by handling, during
slice decoding, when the next token is an array opening. This produces
nested []interface{} slices.

Closes #640.

Add support for decoding JSON arrays of arrays by handling, during
slice decoding, when the next token is an array opening. This produces
nested []interface{} slices.

Closes getsops#640.
@codecov-io
Copy link

Codecov Report

Merging #642 into develop will increase coverage by 0.03%.
The diff coverage is 60%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #642      +/-   ##
===========================================
+ Coverage    37.15%   37.19%   +0.03%     
===========================================
  Files           21       21              
  Lines         2893     2898       +5     
===========================================
+ Hits          1075     1078       +3     
- Misses        1724     1725       +1     
- Partials        94       95       +1
Impacted Files Coverage Δ
stores/json/store.go 53.19% <60%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f350d8...6ee2886. Read the comment docs.

@autrilla autrilla merged commit 84816c3 into getsops:develop Mar 20, 2020
rochaporto pushed a commit to rochaporto/sops that referenced this pull request Jun 22, 2020
Add support for decoding JSON arrays of arrays by handling, during
slice decoding, when the next token is an array opening. This produces
nested []interface{} slices.

Closes getsops#640.
@nilium nilium deleted the nested-arrays-640 branch June 29, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants