Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for go 1.17 and darwin-arm64 (Apple Silicon) #911

Merged
merged 3 commits into from
Mar 1, 2022
Merged

Added support for go 1.17 and darwin-arm64 (Apple Silicon) #911

merged 3 commits into from
Mar 1, 2022

Conversation

nklmilojevic
Copy link
Contributor

@nklmilojevic nklmilojevic commented Jul 26, 2021

  • Changes from go 1.13/1.15 to go 1.16
  • Adds matrix build and binaries for arm64 (Apple Silicon specifically)

@nklmilojevic
Copy link
Contributor Author

Any maintainers around? cc @ajvb

@niksauer
Copy link

I would really appreciate ARM binaries too. Please keep this project up-to-date.

Copy link

@tlamr tlamr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this!

@tlamr
Copy link

tlamr commented Jan 4, 2022

@autrilla @ajvb Hello guys, having arm64 build is something we desperately need.
It is very common these days that people run arm64 only stuff on public cloud (like graviton @ aws), and sops is probably the only tool that does not have arm64 binaries currently.
Would you know who can help with this being review?

Thank you,
Tomas

@kennethredler
Copy link

Only offering a stop gap; I've temporarily worked around the "lack" of arm64 binaries by simply building (in a container):

$ GO111MODULE=on
$ GO15VENDOREXPERIMENT=1
$ ${GOROOT}/bin/go install go.mozilla.org/sops/v3/cmd/sops@v${TARGET_SOPS_VERSION}
$ ${GOPATH}/bin/sops --version

NOTE: This project's README.rst describes a slightly different method:

$ go get -u go.mozilla.org/sops/v3/cmd/sops
$ cd $GOPATH/src/go.mozilla.org/sops/
$ git checkout v${TARGET_SOPS_VERSION}
$ make install

@willjschmitt
Copy link

This would be a very welcome change, since with Apple discontinuing Intel MacBook Pros, it's becoming critical to have built-binaries of sops for arm64 distros. We can build from source, but plenty of toolchains depend on pre-built binaries to load directly

@hugomcfonseca
Copy link

It would be great to take advantage of this PR, and configure the build and release of ARM64 binary for Linux as well.

@fcosta-td
Copy link

@autrilla @jvehent @ajvb appologies for tagging you directly, but could any of you please review this Pull Request? 🙏

MaxPeal added a commit to MaxPeal/sops that referenced this pull request Feb 9, 2022
MaxPeal referenced this pull request in MaxPeal/sops Feb 9, 2022
pick changes form mozilla#911
@ajvb ajvb mentioned this pull request Feb 24, 2022
@slimm609
Copy link

@nklmilojevic can you rebase this off the latest so it picks up the 1.17 changes that were merged?

@nklmilojevic nklmilojevic changed the title Added support for go 1.16 and darwin-arm64 (Apple Silicon) Added support for go 1.17 and darwin-arm64 (Apple Silicon) Mar 1, 2022
@nklmilojevic
Copy link
Contributor Author

@slimm609 done, but still need someone from maintainers to approve it cc @ajvb

@slimm609
Copy link

slimm609 commented Mar 1, 2022

hopefully @rforsythe or @ajvb can approve this and cut a release soon to at least get support for it. There are several golang CVEs that are showing in scans against the binary. Most are false positives but still show in scans for go 1.14,1.15,1.16

@ajvb
Copy link
Contributor

ajvb commented Mar 1, 2022

Thank you very much @nklmilojevic!

@ajvb ajvb merged commit e5f3992 into getsops:develop Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants