switch to openpgp fork #925
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upstream no longer maintains this library: golang/go#44226 Hence bugfixes that are not security relevant are unlikely to get fixed as well as new features. Hence this commit switches to protonmail's fork, which is still regularly updated: https://github.com/ProtonMail/go-crypto
|
I don't expect this to have an impact on binary size since it just replaces the original openpgp library. |
|
Any improvement changing the library? I mean, is |
|
I am not following development too closely, as I am preparing to switch to age. There are a bunch of bugfixes as you can see here, especially for elliptic curve algorithms: https://github.com/ProtonMail/go-crypto/pulls?page=1&q=is%3Apr+is%3Aclosed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upstream no longer maintains this library:
golang/go#44226
Hence bugfixes that are not security relevant are unlikely to get fixed
as well as new features.
Hence this commit switches to protonmail's fork, which is still
regularly updated: https://github.com/ProtonMail/go-crypto