Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Submission: Budibase #1178

Merged
merged 9 commits into from
Jul 30, 2024
Merged

App Submission: Budibase #1178

merged 9 commits into from
Jul 30, 2024

Conversation

sharknoon
Copy link
Contributor

App Submission

App name

Budibase

256x256 SVG icon

logo

Gallery images

Bildschirmfoto am 2024-06-27 um 21 19 41
Bildschirmfoto am 2024-06-27 um 21 20 08
Bildschirmfoto am 2024-06-27 um 21 21 09
Bildschirmfoto am 2024-06-27 um 21 22 00

I have tested my app on:

  • umbrelOS on a Raspberry Pi
  • umbrelOS on an Umbrel Home
  • umbrelOS on Linux VM

@sharknoon
Copy link
Contributor Author

Unfortunately setting user: "1000:1000" in the docker-compose.yml prevents the app from starting.

Copy link
Contributor

@joaovictor-local joaovictor-local left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I installed on umbrelOS 1.2.1 (Intel N100).
Thank you, @sharknoon! I already have some use cases for it 😄

@nmfretz
Copy link
Contributor

nmfretz commented Jul 9, 2024

Fantastic work @sharknoon! This one was fun to play with.

Reviewed and tested. Let's get gallery assets made up.

@nmfretz
Copy link
Contributor

nmfretz commented Jul 9, 2024

@sharknoon, actually one thing that I think we should do:

Right now the single bind mount is set to ${APP_DATA_DIR}/data. This makes sense because budibase is an all-in-one image with a single container directory to bind to the host. But I think we should bind to ${APP_DATA_DIR}/data/budibase instead. The reason being that this will future proof us in the event that a new container is added outside the all-in-one image in the future. For example, an nginx container or some umbrel specific container that requires a bind mount (I dunno, these aren't the greatest example). That means we could just bind ${APP_DATA_DIR}/data/<new-container> and not worry at all about migrating the budibase data into it's own dedicated directory, or worrying about the order of the bind mounts to avoid conflict.

What do you think?

@sharknoon
Copy link
Contributor Author

@nmfretz Yes, that is a good foresight. I have changed and tested it 😀

Copy link

🎉   Linting finished with no errors or warnings   🎉

Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store.

Please review the linting results below and make any necessary changes to your submission.

Linting Results

Severity File Description
ℹ️ budibase/docker-compose.yml Potentially using unsafe user in service "budibase":
The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000.

Legend

Symbol Description
Error: This must be resolved before this PR can be merged.
⚠️ Warning: This is highly encouraged to be resolved, but is not strictly mandatory.
ℹ️ Info: This is just for your information.

@nmfretz
Copy link
Contributor

nmfretz commented Jul 30, 2024

Another app ready to go from the legendary @sharknoon!
Gallery assets: https://github.com/getumbrel/umbrel-apps-gallery/tree/master/budibase

Going live now.

image

@nmfretz nmfretz merged commit 3bef390 into getumbrel:master Jul 30, 2024
1 check passed
@sharknoon sharknoon deleted the budibase branch September 24, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants