Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Submission: Navidrome #1232

Merged
merged 25 commits into from
Aug 5, 2024
Merged

App Submission: Navidrome #1232

merged 25 commits into from
Aug 5, 2024

Conversation

owmsoton
Copy link
Contributor

App Submission

App name

Navidrome

256x256 SVG icon

navidrome

Gallery images

light-albums-view ss-desktop-player ss-mobile-album-view ss-mobile-login ss-mobile-player

I have tested my app on:

  • umbrelOS on a Raspberry Pi
  • umbrelOS on an Umbrel Home
  • umbrelOS on Linux VM

This was referenced Jul 21, 2024
Copy link
Contributor

@sharknoon sharknoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your awesome app submission @owmsoton! I have left you some suggestions below:

navidrome/umbrel-app.yml Outdated Show resolved Hide resolved
navidrome/docker-compose.yml Outdated Show resolved Hide resolved
navidrome/umbrel-app.yml Outdated Show resolved Hide resolved
navidrome/umbrel-app.yml Outdated Show resolved Hide resolved
navidrome/docker-compose.yml Outdated Show resolved Hide resolved
navidrome/docker-compose.yml Show resolved Hide resolved
navidrome/docker-compose.yml Outdated Show resolved Hide resolved
navidrome/docker-compose.yml Show resolved Hide resolved
navidrome/docker-compose.yml Outdated Show resolved Hide resolved
owmsoton and others added 8 commits July 27, 2024 15:46
Co-authored-by: Josua Frank <frank.josua@gmail.com>
Co-authored-by: Josua Frank <frank.josua@gmail.com>
Co-authored-by: Josua Frank <frank.josua@gmail.com>
Co-authored-by: Josua Frank <frank.josua@gmail.com>
Co-authored-by: Josua Frank <frank.josua@gmail.com>
Co-authored-by: Josua Frank <frank.josua@gmail.com>
@owmsoton
Copy link
Contributor Author

@sharknoon Thank you for all your help!

All your suggestions were very helpful and I learned a lot. I ended up improving some details and I believe the corrections were well applied.

I look forward to the next steps.

Thanks again.

Copy link
Contributor

@sharknoon sharknoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome update @owmsoton! You really made a lot of great changes :) I have left 3 suggestions below, after that I think we are ready to go :)

navidrome/docker-compose.yml Outdated Show resolved Hide resolved
navidrome/docker-compose.yml Show resolved Hide resolved
navidrome/docker-compose.yml Outdated Show resolved Hide resolved
owmsoton and others added 3 commits July 28, 2024 13:59
Co-authored-by: Josua Frank <frank.josua@gmail.com>
Co-authored-by: Josua Frank <frank.josua@gmail.com>
@owmsoton
Copy link
Contributor Author

@sharknoon, Just a few small tweaks, but in the end, they make a huge difference for everyone.

Thanks again!

@sharknoon
Copy link
Contributor

Awesome work @owmsoton, thank you so much 👍 @nmfretz I think this app submission is ready to go 😃

@nmfretz
Copy link
Contributor

nmfretz commented Jul 29, 2024

Excellent, thanks for this submission @owmsoton! And for the excellent review @sharknoon. We will get gallery assets prepared and then test the app before going live.

I noticed one minor change we can make:

In the server containers volumes you should be able to remove the rw so that the mount is just:

- ${UMBREL_ROOT}/data/storage/music:/music

And then in the umbrel-app.yml we need to add the following for proper permissions to ${UMBREL_ROOT}/data/storage

permissions:
  - STORAGE_DOWNLOADS

See Plex for example: https://github.com/getumbrel/umbrel-apps/blob/master/plex/umbrel-app.yml

Can you please make this change and let us know if Navidrome is working correctly?

@owmsoton
Copy link
Contributor Author

Can you please make this change and let us know if Navidrome is working correctly?

@nmfretz Application working perfectly with your management.

Thanks to everyone for the help and guidance.

Copy link

github-actions bot commented Aug 5, 2024

🎉   Linting finished with no errors or warnings   🎉

Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store.

@nmfretz
Copy link
Contributor

nmfretz commented Aug 5, 2024

Thanks again for this submission @owmsoton! I have tested and made some final tweaks. The biggest change is that I have changed the bind mount for the music folder on the host such that it is the same folder used by other music apps in the umbrelOS app store. This means, for example, that you can download music files with Lidarr and they will automatically appear in Navidrome.

Gallery assets: https://github.com/getumbrel/umbrel-apps-gallery/tree/master/navidrome

image

Going live to the app store 🎉🎧

@nmfretz nmfretz merged commit 49580db into getumbrel:master Aug 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants