-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App Submission - Simplexmq #1510
base: master
Are you sure you want to change the base?
Conversation
Looks like I will have to build a multi-architecture image for this... |
@arguser thanks for submitting SimpleX 🎉. This one's been pretty heavily requested. We've got our heads down on some other aspects of the codebase, but we have this on our radar and will get to it soon. |
Hey @arguser, thanks for your patience 🙏. Before I dig in too far, do you currently have Simplexmq working? I just took a quick scan through the PR and noticed that both the smp and xftp services are set up as Tor only: environment:
ADDR: ${APP_SIMPLEX_SERVER_SMP_HIDDEN_SERVICE}
PASS: ${APP_PASSWORD} But I don't think the current
The container names for the smp and xftp services will need a I suspect that the tor hidden services won't actually be created when the app starts and so you'll get Also, I'm not familiar with SimpleX chat or running a smp/xftp server. Will the server UI show users their smp and xftp connection details? Or is Simplexmq still in early-days and users would be required to use CLI? |
Hey @nmfretz yes I had it running via TOR. I probably made mistakes while moving the code from my community-apps repo, let me check this out. The web doesn't show the addresses, I have to figure out if there's a configuration for that. So user should check the terminal. |
Sounds good. Let me know when you're ready for me to test!
Ya, I'm thinking we should probably just ship this initial version as tor only as you have done.
Ah darn. That's unfortunate, but nothing we can really do about it besides request this feature from the app devs. It may be good to include instructions on how to check the smp and xftp server addresses, or else include a link to some instructions. |
I'd love a non-TOR option as well. Umbrel comes with the abilty to easily integrate Cloudflare Tunnels or to use Tailscale. I would think it would be pretty simple to shoot a domain to that port and allow others to use it.
|
@nmfretz Update! since v6.1.0 we can show the needed information on the simplex web! https://simplex.chat/docs/server.html#server-information-page I've built images for arm/amd of v6.2.0 and trying to figure out how to initialize the addresses on the container start. On the new version SMP is not starting, probably due to configuration, I'll come back when progress is made. |
@arguser Perfect, that's a huge win for usability! Ping me when you're ready for review. I'm just converting this PR to draft for now for organizational purposes.
@jeremycady good idea. @arguser once you have 6.2.0 up and running we can test configuring with a local hostname and then tunneling from cloudflare. |
|
Severity | File | Description |
---|---|---|
simplexmq/umbrel-app.yml |
"icon" and "gallery" needs to be empty for new app submissions: The "icon" and "gallery" fields must be empty for new app submissions as it is being created by the Umbrel team. |
Legend
Symbol | Description |
---|---|
❌ | Error: This must be resolved before this PR can be merged. |
Warning: This is highly encouraged to be resolved, but is not strictly mandatory. | |
ℹ️ | Info: This is just for your information. |
@nmfretz got it working, had to do some hacky things and the server information doesn't have a proper server addresses fields, so for the time being I'm using others available fields. Tell me what you think! |
App Submission
App name
SimpleXMQ
...
256x256 SVG icon
(Submit an icon with no rounded corners as it will be dynamically rounded with CSS. GitHub doesn't allow uploading SVGs directly, so please upload your icon to an alternate service, like https://svgur.com, and paste the link below.)
We will help finalize this icon before the app goes live in the Umbrel App Store.
...
Gallery images
(Upload 3 to 5 high-quality gallery images (1440x900px) of your app in PNG format, or just upload 3 to 5 screenshots of your app and we'll help you design the gallery images.)
We will help finalize these images before the app goes live in the Umbrel App Store.
...
I have tested my app on: