App Submission: Tor Browser #1928
Conversation
App Submission: LinkStack - Self-hosted open-source Linktree alternative
There was a problem hiding this comment.
Awesome submission @dennysubke! I have left some minor suggestion below.
torbrowser/docker-compose.yml
Outdated
| image: ghcr.io/lkshrk/docker-tor-browser:14.0.3@sha256:9d854697d4afa21a6e6e8fb98d0cf2a82776330c95d9b5bb03f3665096b3f1da | ||
| restart: on-failure | ||
| environment: | ||
| - TZ=Europe/Berlin |
There was a problem hiding this comment.
We should remove the timezone environment variable or set it to utc, as the app can be installed by anyone from around the globe
| - TZ=Europe/Berlin |
There was a problem hiding this comment.
I decided to remove the line.
torbrowser/umbrel-app.yml
Outdated
| defaultUsername: "" | ||
| defaultPassword: "" |
There was a problem hiding this comment.
Those two can be removed as they are already the default. Due to backwards compatability, the three keys above can't be removed unfortunately.
| defaultUsername: "" | |
| defaultPassword: "" |
|
| Severity | File | Description |
|---|---|---|
| ℹ️ | torbrowser/docker-compose.yml |
Potentially using unsafe user in service "web": The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000. |
torbrowser/umbrel-app.yml |
"icon" and "gallery" needs to be empty for new app submissions: The "icon" and "gallery" fields must be empty for new app submissions as it is being created by the Umbrel team. |
Legend
| Symbol | Description |
|---|---|
| ❌ | Error: This must be resolved before this PR can be merged. |
| Warning: This is highly encouraged to be resolved, but is not strictly mandatory. | |
| ℹ️ | Info: This is just for your information. |
|
Thank you @dennysubke for you edits. |
App Submission
Tor Browser
...
Icon
...
Gallery images
...
I have tested my app on: