Skip to content
This repository has been archived by the owner on Nov 5, 2023. It is now read-only.

Reopened: Make password creation form functional #112

Merged
merged 6 commits into from
Jan 27, 2022

Conversation

voltrevo
Copy link
Collaborator

@voltrevo voltrevo commented Jan 24, 2022

Dependent PR

This PR builds on top of #95. Please review and merge that one first.

(Not merging that PR first is the reason for the reopen: #102.)

What is this PR doing?

Adds functionality to the password creation form:

  • Displays password strength using method from previous work
    • Shows weak/strong/etc
    • Description elaborating on weak/strong/etc
    • Horizontal bar with a width corresponding to granular strength measurement
  • Confirm password box shows whether it is correct/incorrect/incomplete
  • Continue button is disabled if a password hasn't been entered or the confirm field doesn't match

I included some naive css this time because I couldn't help it. Just things like background-color: green though. Intended to be thrown away.

Screen Shot 2022-01-14 at 3 59 08 pm

How can these changes be manually tested?

Visit the password creation form and verify the above.

Does this PR resolve or contribute to any issues?

Resolves #97, resolves #98.

Checklist

  • I have manually tested these changes
  • Post a link to the PR in the group chat

Guidelines

  • If your PR is not ready, mark it as a draft
  • The resolve conversation button is for reviewers, not authors
    • (But add a 'done' comment or similar)

@github-actions github-actions bot added the extension Browser extension related label Jan 24, 2022
Copy link
Collaborator Author

@voltrevo voltrevo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously approved by @jacque006 #102

Base automatically changed from bw-90-followup to main January 27, 2022 05:41
@voltrevo voltrevo merged commit 25cb605 into main Jan 27, 2022
@voltrevo voltrevo deleted the bw-97-password-creation-form branch January 27, 2022 05:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
extension Browser extension related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent clicking ahead when the password form isn't done Add functionality to the password creation form
1 participant