Skip to content
This repository has been archived by the owner on Nov 5, 2023. It is now read-only.

Added Arbitrum gas results handling feature #138

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Added Arbitrum gas results handling feature #138

merged 1 commit into from
Feb 15, 2022

Conversation

kcharbo3
Copy link

What is this PR doing?

Adds a feature to retrieve and compute gas costs for Arbitrum whenever the measure-gas.ts script is run for the Arbitrum testnet. This script will send a BLS tx and a normal token transfer tx to the Arbitrum testnet. Then, the contracts/scripts/util/arbitrum-gas-util.ts file is called to pull in gas prices from Arbitrum mainnet and append the results to the contracts/ArbitrumGasCosts.md file.

Also updates the measure-gas script to run with the new version of the BLSExpander contract.

How can these changes be manually tested?

'npx hardhat run scripts/test/measure_gas.ts --network arbitrum_testnet'
command should succeed. After it runs, check the contracts/ArbitrumGasCosts.md file to see if two new rows have been added to the table.

Does this PR resolve or contribute to any issues?

No

Checklist

  • I have manually tested these changes
  • Post a link to the PR in the group chat

Guidelines

  • If your PR is not ready, mark it as a draft
  • The resolve conversation button is for reviewers, not authors
    • (But add a 'done' comment or similar)

@github-actions github-actions bot added the contracts Smart contract related label Feb 14, 2022
Copy link
Collaborator

@jacque006 jacque006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍 . Few nitpicks, but nothing that should hold this back.

Before we merge, could you please run the linter on the new/modified files.

# From project root
cd ./contracts
yarn lint --fix

Also @jzaki would be good to have you take a look as well.

contracts/package.json Show resolved Hide resolved
contracts/scripts/test/measure_gas.ts Outdated Show resolved Hide resolved
contracts/scripts/util/arbitrum_gas_util.ts Outdated Show resolved Hide resolved
contracts/scripts/util/arbitrum_gas_util.ts Outdated Show resolved Hide resolved
@kcharbo3
Copy link
Author

Ran the linter that made some changes. No errors for the new/modified files.

@jacque006 jacque006 marked this pull request as ready for review February 15, 2022 02:52
@jacque006 jacque006 merged commit 40a092d into getwax:main Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contracts Smart contract related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants