Skip to content
This repository has been archived by the owner on Nov 5, 2023. It is now read-only.

Audit feedback #149

Merged
merged 8 commits into from
Feb 23, 2022
Merged

Audit feedback #149

merged 8 commits into from
Feb 23, 2022

Conversation

jacque006
Copy link
Collaborator

@jacque006 jacque006 commented Feb 23, 2022

What is this PR doing?

Integrating audit feedback into main.
Some of these changes have already been approved in #115

How can these changes be manually tested?

cd ./contracts
yarn hardhat test

Does this PR resolve or contribute to any issues?

No

Checklist

  • I have manually tested these changes
  • Post a link to the PR in the group chat

Guidelines

  • If your PR is not ready, mark it as a draft
  • The resolve conversation button is for reviewers, not authors
    • (But add a 'done' comment or similar)

@github-actions github-actions bot added the contracts Smart contract related label Feb 23, 2022
@jacque006
Copy link
Collaborator Author

I cannot approve my own PR, but given that all of these commits are @jzaki & @voltrevo 's and some have been reviewed in other PRs I feel ok to merge in. I ensured contract tests passed and that I did not see any other issues when reviewing the diff.

@jacque006 jacque006 merged commit c785213 into main Feb 23, 2022
@jacque006 jacque006 deleted the audit-feedback branch February 23, 2022 01:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contracts Smart contract related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants