This repository has been archived by the owner on Nov 5, 2023. It is now read-only.
Dapp interaction with eth_sendTransaction
rpc call
#183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
Adds
eth_sendTransaction
rpc endpoint to the QuillController which enables connections with any generic dapp without modification.What should work -
[DEMO] Sending eth
https://user-images.githubusercontent.com/23727056/161533589-70f330b8-0493-4d44-b9e0-0401737a3d30.mov
[DEMO] Contract Interaction
https://user-images.githubusercontent.com/23727056/161534683-fbc2ffb0-7fde-4a45-977b-7eb65a2cbd48.mov
What won't work -
eth_getTransactionReceipt
#179How can these changes be manually tested?
Pull changes, import extension and test with a dapp
Does this PR resolve or contribute to any issues?
closes #67
Checklist
Guidelines
resolve conversation
button is for reviewers, not authors