Skip to content
This repository has been archived by the owner on Nov 5, 2023. It is now read-only.

Dapp interaction with eth_sendTransaction rpc call #183

Merged
merged 2 commits into from
Apr 4, 2022
Merged

Conversation

kautukkundan
Copy link
Contributor

@kautukkundan kautukkundan commented Apr 4, 2022

What is this PR doing?

Adds eth_sendTransaction rpc endpoint to the QuillController which enables connections with any generic dapp without modification.

What should work -

  • Connection with injected provider
  • sending transactions / sending ETH (externally via a dapp)

[DEMO] Sending eth
https://user-images.githubusercontent.com/23727056/161533589-70f330b8-0493-4d44-b9e0-0401737a3d30.mov

[DEMO] Contract Interaction
https://user-images.githubusercontent.com/23727056/161534683-fbc2ffb0-7fde-4a45-977b-7eb65a2cbd48.mov

What won't work -

How can these changes be manually tested?

Pull changes, import extension and test with a dapp

Does this PR resolve or contribute to any issues?

closes #67

Checklist

  • I have manually tested these changes
  • Post a link to the PR in the group chat

Guidelines

  • If your PR is not ready, mark it as a draft
  • The resolve conversation button is for reviewers, not authors
    • (But add a 'done' comment or similar)

@github-actions github-actions bot added the extension Browser extension related label Apr 4, 2022
@jacque006 jacque006 merged commit 36c9069 into main Apr 4, 2022
@jacque006 jacque006 deleted the feat/rpc-sendTx branch April 4, 2022 16:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
extension Browser extension related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate with exisiting dApp
2 participants