This repository has been archived by the owner on Nov 5, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
Adds new jrpc method
eth_setPreferredAggregator
which works like so:This is part of the puzzle to allow dapps to pay for user transactions. In the manual test below we simply use the free aggregator, but this technique will allow a dapp to point to an aggregator which will aggregate only transactions for that dapp for free (in particular, by proxying a paid aggregator and including payment to tx.origin).
How can these changes be manually tested?
Configure your extension to use our new paid aggregator for arbitrum testnet:
Now at https://arbitrum-testnet.blswallet.org/billboard if you try to rent the billboard it'll get stuck forever in 'waiting for confirmation' because this aggregator expects to be paid.
Next, reload and set your preferred aggregator to the free aggregator in the console:
The result of this request should be the string
'ok'
, like this:Then, try to rent the billboard again and this time it should be successful.
Does this PR resolve or contribute to any issues?
Resolves #170
Checklist
Guidelines
resolve conversation
button is for reviewers, not authors