Skip to content
This repository has been archived by the owner on Nov 5, 2023. It is now read-only.

Use prefixKeys to avoid shadowing #239

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Use prefixKeys to avoid shadowing #239

merged 1 commit into from
Jul 5, 2022

Conversation

voltrevo
Copy link
Collaborator

What is this PR doing?

Addresses feedback on other PR: #221 (comment).

How can these changes be manually tested?

Use the cells demo page.

Does this PR resolve or contribute to any issues?

Nope.

Checklist

  • I have manually tested these changes
  • [ ] Post a link to the PR in the group chat NA: Linked in other PR instead

Guidelines

  • If your PR is not ready, mark it as a draft
  • The resolve conversation button is for reviewers, not authors
    • (But add a 'done' comment or similar)

@github-actions github-actions bot added the extension Browser extension related label Jun 15, 2022
@voltrevo voltrevo mentioned this pull request Jun 15, 2022
2 tasks
Copy link
Collaborator

@jacque006 jacque006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution to shadowing. May want to hold merge on this until cells PR goes in.

Base automatically changed from cells to main June 16, 2022 00:44
@jacque006 jacque006 mentioned this pull request Jun 28, 2022
2 tasks
@jacque006
Copy link
Collaborator

@voltrevo Can you update this with main and remove the eslint disables on shadowing from #243 and any other work? You will likely need to cherry pick and force push due to the squashes of the last two large cell PRs.

@voltrevo voltrevo merged commit 565e767 into main Jul 5, 2022
@voltrevo voltrevo deleted the cells-formula-rename branch July 5, 2022 05:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
extension Browser extension related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants