Skip to content
This repository has been archived by the owner on Nov 5, 2023. It is now read-only.

Add extension artifacts on releases #240

Merged
merged 3 commits into from
Jun 22, 2022
Merged

Add extension artifacts on releases #240

merged 3 commits into from
Jun 22, 2022

Conversation

jacque006
Copy link
Collaborator

@jacque006 jacque006 commented Jun 17, 2022 •
edited
Loading

What is this PR doing?

  • Add Chrome, Firefox, and Opera extension artifacts on releases configured to default for the Arbitrum Testnet
  • Remove unused extension env vars
  • Add automation label

How can these changes be manually tested?

  • Checked that quill-chrome.zip loads and can create wallets in Brave
  • After merge, generate a new release

Does this PR resolve or contribute to any issues?

Resolves #237

Checklist

  • I have manually tested these changes
  • Post a link to the PR in the group chat

Guidelines

  • If your PR is not ready, mark it as a draft
  • The resolve conversation button is for reviewers, not authors
    • (But add a 'done' comment or similar)

@github-actions github-actions bot added the extension Browser extension related label Jun 17, 2022
@jacque006 jacque006 changed the title Extension releases Add extension artifact on releases Jun 17, 2022
@jacque006 jacque006 temporarily deployed to extension-release June 17, 2022 20:42 Inactive
@jacque006 jacque006 temporarily deployed to extension-release June 17, 2022 20:48 Inactive
@jacque006 jacque006 temporarily deployed to extension-release June 17, 2022 20:57 Inactive
@jacque006 jacque006 temporarily deployed to extension-release June 17, 2022 21:02 Inactive
@jacque006 jacque006 temporarily deployed to extension-release June 17, 2022 21:45 Inactive
@jacque006 jacque006 temporarily deployed to extension-release June 17, 2022 21:48 Inactive
@jacque006 jacque006 temporarily deployed to extension-release June 17, 2022 21:48 Inactive
@jacque006 jacque006 temporarily deployed to extension-release June 17, 2022 21:49 Inactive
@jacque006 jacque006 temporarily deployed to extension-release June 17, 2022 21:57 Inactive
@jacque006 jacque006 temporarily deployed to extension-release June 17, 2022 21:57 Inactive
@jacque006 jacque006 temporarily deployed to extension-release June 17, 2022 21:57 Inactive
@jacque006
Add workflow for uploading extension on releases
935bdf1 
Add workflow for uploading extension artifacts for chrome, opera, and firefox on release.
Add action for building and uploading extension assets.
Remove unused extension env vars.
@jacque006
Add automation label to labeler
f31ee24
@jacque006 jacque006 marked this pull request as ready for review June 17, 2022 22:10
@jacque006 jacque006 changed the title Add extension artifact on releases Add extension artifacts on releases Jun 17, 2022
kautukkundan
kautukkundan approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@kautukkundan kautukkundan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@jacque006 jacque006 merged commit 17ccc5b into main Jun 22, 2022
@jacque006 jacque006 deleted the extension-releases branch June 22, 2022 16:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kautukkundan kautukkundan kautukkundan approved these changes

@voltrevo voltrevo Awaiting requested review from voltrevo

Assignees
No one assigned
Labels
extension Browser extension related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Publish zip file of extension in releases
2 participants
@jacque006 @kautukkundan