Skip to content
This repository has been archived by the owner on Nov 5, 2023. It is now read-only.

Allow omitting params key when empty #250

Merged
merged 1 commit into from
Jul 6, 2022
Merged

Allow omitting params key when empty #250

merged 1 commit into from
Jul 6, 2022

Conversation

voltrevo
Copy link
Collaborator

@voltrevo voltrevo commented Jul 6, 2022

What is this PR doing?

See title, e.g.
Screen Shot 2022-07-06 at 11 50 02 am

How can these changes be manually tested?

Replicate the screenshot.

Does this PR resolve or contribute to any issues?

Resolves #249

Checklist

  • I have manually tested these changes
  • Post a link to the PR in the group chat

Guidelines

  • If your PR is not ready, mark it as a draft
  • The resolve conversation button is for reviewers, not authors
    • (But add a 'done' comment or similar)

@github-actions github-actions bot added the extension Browser extension related label Jul 6, 2022
@jacque006 jacque006 merged commit b6e057b into main Jul 6, 2022
@jacque006 jacque006 deleted the bw-249-fix-params branch July 6, 2022 03:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
extension Browser extension related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

params param should be made optional
2 participants