-
Notifications
You must be signed in to change notification settings - Fork 46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although we use the $ symbol to prevent shadowing in certain cell calls, I'm against its proliferation into other variable names such as here and elsewhere in this PR. $ is used commonly for templating and in frameworks like Angular, and is not a common TS/JS variable symbol that I have run across. Adds confusion when reading, especially when $
, s
, and S
are in close proximity.
If there are two vars with similar names, I would just be more specific/verbose with naming one of them. This could also be a good case for enabling a lint rule around variable naming, but don't want to have to disable on every line with $ to prevent shadowing :)
Hmm fair enough. I was still figuring out how I felt about it too. Will fix. |
Fixed |
What is this PR doing?
Enables sending ETH
How can these changes be manually tested?
Replicate behavior shown in video.
Does this PR resolve or contribute to any issues?
Resolves #230.
Checklist
Guidelines
resolve conversation
button is for reviewers, not authors