This repository has been archived by the owner on Nov 5, 2023. It is now read-only.
Use QuillContext in Confirm dialog #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voltrevo
commented
Jul 12, 2022
| const tx = data.transactions.value.outgoing.find( | ||
| (t: any) => t.id === txid, | ||
| ); | ||
| setActions(tx.actions); |
There was a problem hiding this comment.
If tx was not found this would have thrown an error. This is now handled more gracefully as <>Error: Tx not found</>.
voltrevo
commented
Jul 12, 2022
| const fetchTx = async () => { | ||
| const data = await storage.local.get('transactions'); | ||
| const tx = data.transactions.value.outgoing.find( | ||
| (t: any) => t.id === txid, |
There was a problem hiding this comment.
Use of any here is what really prompted this. Trying to clean up all our linting issues.
voltrevo
force-pushed
the
use-quill-in-confirm
branch
from
52a6870
to
676471b
Compare
kautukkundan
approved these changes
Jul 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
See title. This fixes the usage of
anyand also makes future development of the confirm dialog (eg showing currency conversion) easier because we have access to our stuff.How can these changes be manually tested?
Check the confirm dialog still works, eg by sending eth within the extension.
Does this PR resolve or contribute to any issues?
Nope.
Checklist
Guidelines
resolve conversationbutton is for reviewers, not authors