Skip to content
This repository has been archived by the owner on Nov 5, 2023. It is now read-only.

Specify deps for carousel correctly #266

Merged
merged 1 commit into from
Jul 17, 2022
Merged

Specify deps for carousel correctly #266

merged 1 commit into from
Jul 17, 2022

Conversation

voltrevo
Copy link
Collaborator

@voltrevo voltrevo commented Jul 12, 2022

Dependent PR

This PR builds upon #265. Please merge that PR first.

What is this PR doing?

See title. This is our last remaining lint warning 🎉.

How can these changes be manually tested?

Note this change applies to the popup:

Screen Shot 2022-07-12 at 12 57 36 pm

It's currently disabled, so apply this diff to re-enable it temporarily:

diff --git extension/source/Popup/index.tsx extension/source/Popup/index.tsx
index 96d6d1d..764e92d 100644
--- extension/source/Popup/index.tsx
+++ extension/source/Popup/index.tsx
@@ -1,17 +1,17 @@
 import { runtime, tabs } from 'webextension-polyfill';
 
-// import ReactDOM from 'react-dom';
+import ReactDOM from 'react-dom';
 
-// import './styles.scss';
-// import '../styles/index.scss';
-// import WelcomeScreen from './components/WelcomeScreen';
+import './styles.scss';
+import '../styles/index.scss';
+import WelcomeScreen from './components/WelcomeScreen';
 
-// ReactDOM.render(<WelcomeScreen />, document.getElementById('popup-root'));
+ReactDOM.render(<WelcomeScreen />, document.getElementById('popup-root'));
 
 // We're not currently using the popup for anything, so just go straight to the
 // full view and close ourselves.
-tabs.create({
-  url: runtime.getURL('home.html'),
-});
+// tabs.create({
+//   url: runtime.getURL('home.html'),
+// });
 
-window.close();
+// window.close();

Check that the Carousel is working correctly (auto-transitions every 5s, radio buttons allow selecting image and disable auto-transitions).

Does this PR resolve or contribute to any issues?

Nope.

Checklist

  • I have manually tested these changes
  • Post a link to the PR in the group chat

Guidelines

  • If your PR is not ready, mark it as a draft
  • The resolve conversation button is for reviewers, not authors
    • (But add a 'done' comment or similar)

@github-actions github-actions bot added the extension Browser extension related label Jul 12, 2022
@voltrevo voltrevo mentioned this pull request Jul 12, 2022
2 tasks
Base automatically changed from bw-145-fix-react-table-typing to main July 17, 2022 18:23
@kautukkundan kautukkundan merged commit 1a80eb4 into main Jul 17, 2022
@kautukkundan kautukkundan deleted the fix-carousel branch July 17, 2022 18:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
extension Browser extension related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants