This repository has been archived by the owner on Nov 5, 2023. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests failing, looking into this now |
JohnGuilding
added
bug
blakecduncan
approved these changes
Aug 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
This PR updates the aggregator private key:
PRIVATE_KEY_AGGin./aggregator/.env.example. Previously, this private key belonged to the first account that the hardhat node provides. This has been updated to the private key from the 3rd account in the account list that hardhat provides.How can these changes be manually tested?
These changes have been tested by running bls wallet locally, attempting to send transactions, and observing there is no nonce too low errors.
Does this PR resolve or contribute to any issues?
A periodic nonce mismatch issue occurs when the aggregator tries to submit a batch. This is because the private key used by the aggregator is the same as the default contract deployer. This change swaps this aggregator private key for another one so there is no longer a clash.
Error:
Checklist
Guidelines
resolve conversationbutton is for reviewers, not authors