This repository has been archived by the owner on Nov 5, 2023. It is now read-only.
Fix issue getting existing wallet addresses #340
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update BlsWalletWrapper.Address() to check for existing wallet address from the VerifiicationGateway before calculating the CREATE2 address for a new wallet from a given private key.
jacque006
requested review from
jzaki,
voltrevo,
kautukkundan,
blakecduncan and
JohnGuilding
github-actions
bot
added
aggregator
Remove old send_eth script
jacque006
force-pushed
the
bug/recovery-address
branch
from
ca9e2e8
to
c0f39ab
Compare
jacque006
changed the title
jacque006
changed the title
|
I spoke with Blake about this, and the fix is in the branch I'm working on, there's still another issue around this I'll be resolving too. |
voltrevo
approved these changes
Sep 15, 2022
2 tasks
|
Will update & re-evaluate this once #350 is merged to |
14 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
BlsWalletWrapper.connect&Addressif a wallet recovery is detected.sendEthHardhat utility task , remove oldsend_ethscript.How can these changes be manually tested?
BlsWalletWrapper.Address()for a wallet after recovering to a new public keysendEthtask.Does this PR resolve or contribute to any issues?
No
Checklist
Guidelines
resolve conversationbutton is for reviewers, not authors