Skip to content
This repository has been archived by the owner on Nov 5, 2023. It is now read-only.

Audit fixes 1-4 and BLSWalletWrapper changes #350

Merged
merged 20 commits into from
Oct 27, 2022
Merged

Audit fixes 1-4 and BLSWalletWrapper changes #350

merged 20 commits into from
Oct 27, 2022

Commits on Oct 4, 2022

  1. Sign key hash with chainid and UserOp - protect from rogue key attack… 

    … (01)
    @jzaki
    jzaki committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    a485d84 View commit details
    Browse the repository at this point in the history

  2. Increment nonce before operation - protect from relpay reentrancy (02)

    @jzaki
    jzaki committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    e2ee017 View commit details
    Browse the repository at this point in the history

  3. Restrict Owner functions from ProxyAdmin call (03)

    @jzaki
    jzaki committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    192db97 View commit details
    Browse the repository at this point in the history

  4. Sign wallet address in msg (04) - WIP

    @jzaki
    jzaki committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    4147726 View commit details
    Browse the repository at this point in the history

  5. Sign wallet address in msg (04) tests

    @jzaki
    jzaki committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    f0a3b56 View commit details
    Browse the repository at this point in the history

  6. WIP Fix client tests, run agg tests on contract changes

    @jacque006
    jacque006 committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    998ee6b View commit details
    Browse the repository at this point in the history

  7. WIP Remove main branch requirement to run CI steps

    @jacque006
    jacque006 committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    5a33e43 View commit details
    Browse the repository at this point in the history

  8. WIP Add back in main restriction for push workflow trigger

    @jacque006
    jacque006 committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    def1eaf View commit details
    Browse the repository at this point in the history

  9. WIP Add build test to client CI process

    @jacque006
    jacque006 committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    17052cd View commit details
    Browse the repository at this point in the history

  10. WIP Fix typechain import path

    @jacque006
    jacque006 committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    1481c69 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2022

  1. Minor fixes from review

    @jzaki
    jzaki committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    f2a490a View commit details
    Browse the repository at this point in the history

  2. Remove gateway param to return compatible to server tests

    @jzaki
    jzaki committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    163af9d View commit details
    Browse the repository at this point in the history

  3. Remove unneeded arg, expand on any cast.

    @jacque006
    jacque006 committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    c3e79a7 View commit details
    Browse the repository at this point in the history

  4. Add wallet AddressFromPublicKey function

    @jacque006
    jacque006 committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    92b9b13 View commit details
    Browse the repository at this point in the history

  5. Bump bls-wallet-clients to v0.8.0

    @jacque006
    jacque006 committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    2d28b7b View commit details
    Browse the repository at this point in the history

  6. Bump bls-wallet-clients version to experimental v0.8.0 

    Update aggregator BundleService to work with new signature payload which includes wallet address.
    @jacque006
    jacque006 committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    c2bf4bb View commit details
    Browse the repository at this point in the history

  7. Fix import string & contract lint

    @jacque006
    jacque006 committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    647c1bb View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2022

  1. Merge branch 'main' of github.com:web3well/bls-wallet into contract-a… 

    …udit
    @jacque006
    jacque006 committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    5b7231b View commit details
    Browse the repository at this point in the history

  2. Add replay attack test after recovery

    @jacque006
    jacque006 committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    4bc4701 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2022

  1. Add getOperationResults to cleints 

    Add getOperationResults to bls-wallet-clients to allow consumers to more easily get at operation errors.
Change existing test case to use getOperationResults.
Add message to require used to prevent ownership changes to proxy admin.
    @jacque006
    jacque006 committed Oct 26, 2022
    1 Configuration menu
    Copy the full SHA
    6379006 View commit details
    Browse the repository at this point in the history