This repository has been archived by the owner on Nov 5, 2023. It is now read-only.
Import pre-existing seed phrase during Onboarding #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacque006
reviewed
Oct 20, 2022
Comment on lines
21
to
24
| const split = m.split(' '); | ||
| if (split.length === 12) { | ||
| setMnemonic(split); | ||
| } |
There was a problem hiding this comment.
- We should display some sort of error message in the UI if the mnemonic is not valid, and not allow the user to set it
- You should be able to use ethers.Wallet.fromMnemonic to validate it is correct (I assume it throws an error), rather than just doing the length check. This will ensure it has the correct words from the language list (english for now) as well.
There was a problem hiding this comment.
updated in 8f17aa9
The set mnemonic button won't show and an error message will pop-up if the words aren't compatible with BIP-39 standard.
kautukkundan
force-pushed
the
existing-seed
branch
2 times, most recently
from
ca57a34
to
0904d81
Compare
kautukkundan
force-pushed
the
existing-seed
branch
from
f9b178d
to
8f17aa9
Compare
jacque006
approved these changes
Oct 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
Adds ability to use existing seed phrase during wallet generation
How can these changes be manually tested?
pull latest version, remove older extension, import again, use any seed
Does this PR resolve or contribute to any issues?
closes #318
Checklist
Guidelines
resolve conversationbutton is for reviewers, not authors