Skip to content
This repository has been archived by the owner on Nov 5, 2023. It is now read-only.

Add links to contract deployments to README. #358

Merged
merged 1 commit into from
Oct 27, 2022
Merged

Conversation

jacque006
Copy link
Collaborator

What is this PR doing?

Adding links & descriptions for current contract deployments on testnets

How can these changes be manually tested?

👀 & 🖱️

Does this PR resolve or contribute to any issues?

No

Checklist

  • I have manually tested these changes
  • Post a link to the PR in the group chat

Guidelines

  • If your PR is not ready, mark it as a draft
  • The resolve conversation button is for reviewers, not authors
    • (But add a 'done' comment or similar)

@jacque006 jacque006 added documentation Improvements or additions to documentation contracts Smart contract related devExp 3rd-party user friction labels Oct 24, 2022
@github-actions github-actions bot removed the contracts Smart contract related label Oct 24, 2022
@jacque006 jacque006 mentioned this pull request Oct 24, 2022
2 tasks
README.md Outdated
See [./contracts/networks](./contracts/networks/) for a list of all contract deployment (network) manifests. Have an L2/rollup testnet you'd like BLS Wallet deployed on? [Open an issue](https://github.com/web3well/bls-wallet/issues/new) or [Deploy it yourself](./docs/remote_development.md)

- [Arbitrum Goerli](./contracts/networks/arbitrum-goerli.json)
- [Arbitrum Rinkby](./contracts/networks/arbitrum-testnet.json) (depreciated, outdated)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#nit
depreciated => deprecated

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My spelling continues to be malformed, and my teammates continue to show their astounding English skills. Fixed.

Copy link
Contributor

@kautukkundan kautukkundan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

Co-authored-by: outsider-analytics <outsideranalytics@gmail.com>
@jacque006 jacque006 merged commit b06435e into main Oct 27, 2022
@jacque006 jacque006 deleted the docs/add-deployments branch October 27, 2022 03:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
devExp 3rd-party user friction documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants