-
Notifications
You must be signed in to change notification settings - Fork 46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to move in the future to https://github.com/docker/build-push-action so we don't need to maintain a separate docker build script and can take advantage of features such as caching, platforms such as ARM, and others
branches: | ||
- 'main' | ||
paths: | ||
- 'aggregator/**' | ||
- '.github/workflows/aggregator-dockerhub.yml' | ||
|
||
defaults: | ||
run: | ||
working-directory: ./aggregator | ||
|
||
env: | ||
DENO_VERSION: 1.x | ||
|
||
jobs: | ||
push: | ||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- uses: actions/checkout@v3 | ||
- uses: denoland/setup-deno@v1 | ||
with: | ||
deno-version: ${{ env.DENO_VERSION }} | ||
- run: git show HEAD | ||
- run: echo ${{ secrets.DOCKERHUB_TOKEN }} | docker login --username blswalletghactions --password-stdin | ||
- run: ./programs/build.ts --image-name blswallet/aggregator --image-only --also-tag-latest --push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's little cost to pushing up every commit. This also will make it easier to share agg images early when testing bug fixes with external devs, and will make it easier to test the image in the future to ensure it is working.
branches: | |
- 'main' | |
paths: | |
- 'aggregator/**' | |
- '.github/workflows/aggregator-dockerhub.yml' | |
defaults: | |
run: | |
working-directory: ./aggregator | |
env: | |
DENO_VERSION: 1.x | |
jobs: | |
push: | |
runs-on: ubuntu-latest | |
steps: | |
- uses: actions/checkout@v3 | |
- uses: denoland/setup-deno@v1 | |
with: | |
deno-version: ${{ env.DENO_VERSION }} | |
- run: git show HEAD | |
- run: echo ${{ secrets.DOCKERHUB_TOKEN }} | docker login --username blswalletghactions --password-stdin | |
- run: ./programs/build.ts --image-name blswallet/aggregator --image-only --also-tag-latest --push | |
paths: | |
- 'aggregator/**' | |
- '.github/workflows/aggregator-dockerhub.yml' | |
defaults: | |
run: | |
working-directory: ./aggregator | |
env: | |
DENO_VERSION: 1.x | |
jobs: | |
push: | |
runs-on: ubuntu-latest | |
steps: | |
- uses: actions/checkout@v3 | |
- uses: denoland/setup-deno@v1 | |
with: | |
deno-version: ${{ env.DENO_VERSION }} | |
- run: git show HEAD | |
- run: echo ${{ secrets.DOCKERHUB_TOKEN }} | docker login --username blswalletghactions --password-stdin | |
- run: ./programs/build.ts --image-name blswallet/aggregator --image-only --push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can then tag in another step on main
or git tag/GH release
push-latest
runs-on: ubuntu-latest
if: github.ref == 'refs/heads/main'
needs: [push]
steps:
- run: docker tag IMAGE blswallet/aggregator:latest # or version
- run: docker push blswallet/aggregator:latest
What is this PR doing?
build.ts
for pushing docker images to dockerhubHow can these changes be manually tested?
./manualTests/mint1ViaAggregator.ts
against itDoes this PR resolve or contribute to any issues?
Resolves #91.
Checklist
Guidelines
resolve conversation
button is for reviewers, not authors