Add accounts, blocks, & network status method tests #512
Conversation
JohnGuilding
force-pushed
the
bls-provider-accounts-blocks-and-network-status-methods
branch
from
0c53981
to
ed6766a
Compare
| const expectedTransactionCountAtEaliestBlockTag = | ||
| await blsProvider.getTransactionCount(address, "earliest"); |
There was a problem hiding this comment.
This is the same expression as transactionCountAtEaliestBlockTag. Should we be using regularProvider here?
There was a problem hiding this comment.
Good catch, changed
| await blsProvider.getTransactionCount(address, "earliest"); | ||
|
|
||
| // Assert | ||
| expect(transactionCount).to.equal(expectedTransactionCount); |
There was a problem hiding this comment.
Why is the blsProvider expected to give the same transaction count as regularProvider?
Shouldn't blsProvider be calling nonce() on the contract? And regularProvider would just return zero I suppose? Or error?
There was a problem hiding this comment.
Does blsSigner.getAddress() return an EOA account somehow? I'd expect a BLSWallet.
There was a problem hiding this comment.
Ah yeah missed this completely. Because blsProvider was just calling the ethers version of getTransactionCount, both calls were returning 0.
Does blsSigner.getAddress() return an EOA account somehow? I'd expect a BLSWallet.
blsSigner.getAddress() does return the bls wallet address.
Solution was to add a new getTransactionCount method onto the blsProvider itself that follows similar logic to BlsWalletWrapper, with the addition of being able to query by block tag. let me know what you think
|
|
||
| // Act | ||
| const storage1 = await blsProvider.getStorageAt(mockERC20.address, 1); | ||
| console.log(storage1); |
JohnGuilding
force-pushed
the
bls-provider-accounts-blocks-and-network-status-methods
branch
from
2b96f5c
to
c9c03a6
Compare
JohnGuilding
deleted the
bls-provider-accounts-blocks-and-network-status-methods
branch
What is this PR doing?
Add tests for provider Accounts, Blocks & Network Status Methods.
Relevant methods:
How can these changes be manually tested?
Run integration tests
Does this PR resolve or contribute to any issues?
#380
Checklist
Guidelines
resolve conversationbutton is for reviewers, not authors