Skip to content
This repository has been archived by the owner on Nov 5, 2023. It is now read-only.

Expanders followup #556

Merged
merged 2 commits into from
Mar 28, 2023
Merged

Expanders followup #556

merged 2 commits into from
Mar 28, 2023

Conversation

voltrevo
Copy link
Collaborator

@voltrevo voltrevo commented Mar 15, 2023

Dependent PR

This PR depends on:

That PR should be merged first.

What is this PR doing?

Addresses comments on previous PRs:

  • Avoids underscores in typechain factories (comment)
  • Adds docs to some key exported classes (comment)

How can these changes be manually tested?

yarn hardhat test (No functionality changes expected)

Does this PR resolve or contribute to any issues?

Nope

Checklist

  • I have manually tested these changes
  • Post a link to the PR in the group chat

Guidelines

  • If your PR is not ready, mark it as a draft
  • The resolve conversation button is for reviewers, not authors
    • (But add a 'done' comment or similar)

@github-actions github-actions bot added clients contracts Smart contract related labels Mar 15, 2023
This was referenced Mar 15, 2023
@voltrevo voltrevo marked this pull request as ready for review March 15, 2023 07:54
@voltrevo voltrevo changed the base branch from contract-updates to main March 17, 2023 00:32
@voltrevo voltrevo changed the base branch from main to contract-updates March 17, 2023 00:32
@jacque006 jacque006 merged commit fcbfd7c into contract-updates Mar 28, 2023
@jacque006 jacque006 deleted the expanders-followup branch March 28, 2023 02:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants