This repository has been archived by the owner on Nov 5, 2023. It is now read-only.
main -> contract updates #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o merge-in-contract-updates
…o merge-in-contract-updates
Add new safe deployer address as 'n/a' to existing contract deploys. Add assert-browserify and resolution to webpack. Rename factory func to camelcase. Use sign with gas estimate over older sign.
Increase gas limit per bundle for BundleService submit test cases. Add event when simulating adding a bundle would exceeed max gas per bundle limit with details. Link emit func to AggregatationStrategy when created in test fixture.
…o merge-in-contract-updates
Parallelize async calls in recoverWallet. Remove unneeded camelcase lint disables. Add comment for human reable times to expiry durations.
- use correct nonce in multiple operation sendTransaction error test - add Operation gas property to missing test setup - use new VG address
- set nonce to zero at all times in provider.estimateGas to prevent "BLSWallet: only callable with current nonce" error (see comment)
- update invalid transaction expected error message (due to using signWithGasEstimate in BlsSigner) - fix sign tx batch test by replicating what BlsSigner logic does cleanup - remove console logs - remove unnecessary transaction.to check
- sinon fake for getRandomBlsPrivateKey was resulting in throwawayBlsWalletWrapper nonce increasing when it should stay at zero - fake was using signers[0] private key - fix was to use fresh signer that wouldn't have its nonced changed in any other test
…-and-pay-aggregator-fees 551 run quill against geth node and pay aggregator fees
Co-authored-by: ksingh-vertex <ksingh@vertex.com>
Merge in contract updates
github-actions
bot
added
aggregator
Configure cors for geth dev
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.