Skip to content
This repository has been archived by the owner on Nov 5, 2023. It is now read-only.

Audit Fix 06 Integration branch #606

Merged
merged 10 commits into from
Jun 28, 2023
Merged

Audit Fix 06 Integration branch #606

merged 10 commits into from
Jun 28, 2023

Conversation

jacque006
Copy link
Collaborator

@jacque006 jacque006 commented Jun 27, 2023

What is this PR doing?

Integrating #604 into main

How can these changes be manually tested?

  • Attempt to upgrade a v1 BLS Wallet, which should revert. Test cases cover.

Does this PR resolve or contribute to any issues?

No

Checklist

I have manually tested these changes Covered by contract tests, no client implementation or known integrations.

  • Post a link to the PR in the group chat

Guidelines

  • If your PR is not ready, mark it as a draft
  • The resolve conversation button is for reviewers, not authors
    • (But add a 'done' comment or similar)

@github-actions github-actions bot added the contracts Smart contract related label Jun 27, 2023
Remove signatureExpiryTimestamp param from setBLSKeyForWallet as it is no longer used.
Rework branching logic in setBLSKeyForWallet to use single if.
@github-actions github-actions bot added aggregator Aggregator backend related aggregator-proxy Aggregator proxy related clients extension Browser extension related labels Jun 27, 2023
@jacque006 jacque006 marked this pull request as ready for review June 27, 2023 20:16
@jacque006 jacque006 mentioned this pull request Jun 27, 2023
1 task
Copy link
Collaborator

@JohnGuilding JohnGuilding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jacque006 jacque006 merged commit 4863733 into main Jun 28, 2023
@jacque006 jacque006 deleted the merge-in-contract-updates branch June 28, 2023 21:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
aggregator Aggregator backend related aggregator-proxy Aggregator proxy related clients contracts Smart contract related extension Browser extension related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants