This repository has been archived by the owner on Nov 5, 2023. It is now read-only.
Wallet key recovery #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacque006
approved these changes
Dec 22, 2021
Comment on lines
+17
to
+59
| bytes32 public recoveryHash; | ||
| bytes32 pendingRecoveryHash; | ||
| uint256 pendingRecoveryHashTime; | ||
| bytes public approvedProxyAdminFunction; | ||
| bytes pendingPAFunction; | ||
| uint256 pendingPAFunctionTime; | ||
|
|
||
| // BLS variables | ||
| uint256[4] public blsPublicKey; | ||
| uint256[4] pendingBLSPublicKey; | ||
| uint256 pendingBLSPublicKeyTime; | ||
| address public trustedBLSGateway; | ||
| address pendingBLSGateway; | ||
| uint256 pendingGatewayTime; | ||
|
|
||
| event PendingRecoveryHashSet( | ||
| bytes32 pendingRecoveryHash | ||
| ); | ||
| event PendingBLSKeySet( | ||
| uint256[4] pendingBLSKey | ||
| ); | ||
| event PendingGatewaySet( | ||
| address pendingGateway | ||
| ); | ||
| event PendingProxyAdminFunctionSet( | ||
| bytes pendingProxyAdminFunction | ||
| ); | ||
|
|
||
| event RecoveryHashUpdated( | ||
| bytes32 oldHash, | ||
| bytes32 newHash | ||
| ); | ||
| event BLSKeySet( | ||
| uint256[4] oldBLSKey, | ||
| uint256[4] newBLSKey | ||
| ); | ||
| event GatewayUpdated( | ||
| address oldGateway, | ||
| address newGateway | ||
| ); | ||
| event ProxyAdminFunctionApproved( | ||
| bytes approvedProxyAdmin | ||
| ); |
There was a problem hiding this comment.
Something to consider for the future would be to break this down into separate abstract component contracts that manage the state/pending/recovery of these sensitive fields. i.e. blsPublicKey and its pending fields, events, mutators, and set pending calls, then have BLSWallet inherit them. This would reduce the code size/complexity of BLSWallet.sol, and make it easier to break out isolated unit test suites for them.
There was a problem hiding this comment.
Agreed, at that stage it would be good to factor in upgradability of wallets (bls and potentially non-bls). Which needs to consider the inheritance order since memory locations when upgrading are important. -> Created #73
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
Adding recovery functionality to wallets
How can these changes be manually tested?
yarn hardhat testfromcontractsDoes this PR resolve or contribute to any issues?
Closes #70
Checklist
Guidelines
resolve conversationbutton is for reviewers, not authors