Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 #106

Merged
merged 9 commits into from
Nov 6, 2024
Merged

V2 #106

merged 9 commits into from
Nov 6, 2024

Conversation

paul-paliychuk
Copy link
Contributor

@paul-paliychuk paul-paliychuk commented Nov 6, 2024

Important

Update version to 2.1.0 and add context field to Memory interface with serialization support.

  • Version Update:
    • Update version to 2.1.0 in package.json, Client.ts files across document, graph, edge, episode, node, group, memory, and user directories.
  • Memory Context:
    • Add context field to Memory interface in Memory.ts.
    • Update serialization for context in Memory.ts in serialization/types.
  • Misc:
    • Change classification.name to classification.label in memory_example.ts.

This description was created by Ellipsis for 60a37c9. It will automatically update as commits are pushed.

@paul-paliychuk paul-paliychuk merged commit 09d1b89 into main Nov 6, 2024
2 checks passed
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 60a37c9 in 1 minute and 17 seconds

More details
  • Looked at 625 lines of code in 12 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. examples/memory/memory_example.ts:43
  • Draft comment:
    Avoid using non-null assertion operator ! on user.userId. Ensure user.userId is defined before using it.
  • Reason this comment was not posted:
    Comment did not seem useful.
2. examples/memory/memory_example.ts:92
  • Draft comment:
    Ensure that classification.label is the correct property to use instead of classification.name. Verify that label exists and is intended for this use.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_rRAyv8TzBM6dNZ6h


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant