Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Older Docker Versions in docker-compose.yaml #120

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

sweep-ai[bot]
Copy link
Contributor

@sweep-ai sweep-ai bot commented Jul 4, 2023

This PR modifies the docker-compose.yaml file to support older versions of Docker. The configs option, which is not supported in older Docker versions, has been replaced with a volumes option. This change allows the config.yaml file to be made available to the Zep container, ensuring compatibility with all Docker versions.

Please review and let me know if any changes are required.

Fixes #119.

To checkout this PR branch, run the following command in your terminal:

git checkout sweep/feature/older-docker-support

@sweep-ai sweep-ai bot temporarily deployed to build-test July 4, 2023 18:21 Inactive
Copy link
Contributor Author

@sweep-ai sweep-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes required. The modifications in the docker-compose.yaml file are consistent and make sense. The configs feature has been replaced with the volumes feature for mapping the config.yaml file in the zep service, which is a common practice for single-host deployments. Good job!

@danielchalef danielchalef merged commit fc056eb into main Jul 4, 2023
4 checks passed
@danielchalef danielchalef deleted the sweep/feature/older-docker-support branch July 4, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sweep: Modify the docker compose to support older docker versions
1 participant