new anthropic models #347
Merged
new anthropic models #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to d4bcc56 in 39 seconds
More details
- Looked at
49lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. pkg/llms/llm_base.go:171
- Draft comment:
Ensure that all newly added models inValidAnthropicLLMsare also reflected inMaxLLMTokensMapwith appropriate token limits. This is crucial for maintaining consistency and ensuring that each model has defined behavior regarding its token limits. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_wrgLTe77ugwsx2yh
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
Hey @danielchalef - When I run zep via docker-compose I don't get this diff? Do I need to rebuild something to make it work? (Maybe it's cached in the docker images?) |
|
@idvorkin try |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Added new Anthropic models and updated their token limits in
pkg/llms/llm_base.go.Key points:
ValidAnthropicLLMsinpkg/llms/llm_base.goclaude-3-5-sonnet-20240620claude-3-opus-20240229claude-3-sonnet-20240229claude-3-haiku-20240307MaxLLMTokensMapinpkg/llms/llm_base.gowith new token limits for the added models (200,000 tokens each).Generated with ❤️ by ellipsis.dev