Add gpt-4o-mini to MaxLLMTokensMap #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 276818d in 5 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. pkg/llms/llm_base.go:188
- Draft comment:
Ensure that the token limit for "gpt-4o-mini" is consistent with its intended use and matches any documentation or specifications. The current limit is set to 128,000 tokens. - Reason this comment was not posted:
Confidence changes required:33%
The addition of "gpt-4o-mini" to the MaxLLMTokensMap is consistent with its presence in ValidOpenAILLMs, ensuring consistency across the codebase.
Workflow ID: wflow_f19EMqSp7XvTLboX
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
raffareis
had a problem deploying
to
build-test
GitHub Actions
Failure
paul-paliychuk
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Added
gpt-4o-minitoMaxLLMTokensMapinpkg/llms/llm_base.gowith a token limit of 128,000.Key points:
gpt-4o-minitoMaxLLMTokensMapinpkg/llms/llm_base.go.gpt-4o-minito 128,000 tokens.Generated with ❤️ by ellipsis.dev