Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: Publish image action changes #362

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Conversation

paul-paliychuk
Copy link
Collaborator

@paul-paliychuk paul-paliychuk commented Sep 25, 2024

Important

Adds Depot CLI setup to GitHub Actions workflow in docker-publish.yml, updating checkout and build steps.

  • Workflow Changes:
    • Adds Depot CLI setup step using depot/setup-action@v1 in docker-publish.yml.
    • Updates checkout action to actions/checkout@v3 and modifies ref handling.
    • Simplifies Docker metadata extraction and build steps, removing manual version extraction.

This description was created by Ellipsis for fe2e2ef. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 7222595 in 14 seconds

More details
  • Looked at 14 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_PxlQF6udLaiz0l6a


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

.github/workflows/docker-publish.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on fe2e2ef in 25 seconds

More details
  • Looked at 82 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. .github/workflows/docker-publish.yml:23
  • Draft comment:
    The Depot CLI setup step is already present. Ensure this is intentional and not redundant with the new changes.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR description mentions adding a Depot CLI setup step, but the workflow file already contains a step for setting up Depot CLI. This might be redundant or incorrectly described in the PR.

Workflow ID: wflow_5qdajjdTeNapx6oV


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@paul-paliychuk paul-paliychuk changed the title chore: Add depot setup action revert: Publish image action changes Sep 25, 2024
Copy link
Member

@danielchalef danielchalef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@paul-paliychuk paul-paliychuk merged commit 0e8618e into main Sep 25, 2024
4 checks passed
@paul-paliychuk paul-paliychuk deleted the update-release-action branch September 25, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants