Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix permissions on release runner #364

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

paul-paliychuk
Copy link
Collaborator

@paul-paliychuk paul-paliychuk commented Sep 25, 2024

Important

Add contents: read and id-token: write permissions to docker-image job in docker-publish.yml.

  • Permissions:
    • Added contents: read and id-token: write permissions to the docker-image job in .github/workflows/docker-publish.yml.

This description was created by Ellipsis for f3f5611. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to f3f5611 in 6 seconds

More details
  • Looked at 14 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. .github/workflows/docker-publish.yml:17
  • Draft comment:
    The added permissions 'contents: read' and 'id-token: write' are appropriate for the actions in this workflow. Ensure that these permissions are necessary for the intended operations, especially the 'id-token: write' which is often used for OIDC authentication.
  • Reason this comment was not posted:
    Confidence changes required: 20%
    The permissions added in the PR are appropriate for the actions being performed in the workflow. The 'contents: read' permission is needed for checking out the repository, and 'id-token: write' is necessary for authentication purposes, possibly for OIDC. No issues found with the changes.

Workflow ID: wflow_TEHfIMhDHPsCxEnC


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@paul-paliychuk paul-paliychuk merged commit 38493e4 into main Sep 25, 2024
4 checks passed
@paul-paliychuk paul-paliychuk deleted the fix-release-actions-permissions branch September 25, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant