Merge pull request Shardj#7 from abhishek-algoworks/FE-336-sf-agent-p…

…anel-classic-login-fails-in-chrome

DTPORTAL-19293 SF Agent Panel (Classic) - Login fails in Chrome

library/Zend/Session.php

@@ -321,6 +321,9 @@ public static function regenerateId()
         } else {
             if (!self::$_unitTestEnabled) {
                 session_regenerate_id(true);
+
+                // Force Samesite cookie
+                self::sameSiteCookieWorkaroundPrePhp74();
             }
             self::$_regenerateIdState = 1;
         }
@@ -485,6 +488,9 @@ public static function start($options = false)
 
             $startedCleanly = session_start();
 
+            // Force Samesite cookie
+            self::sameSiteCookieWorkaroundPrePhp74();
+
             if (self::$_throwStartupExceptions) {
                 restore_error_handler();
             }
@@ -914,4 +920,25 @@ public static function isReadable()
         return parent::$_readable;
     }
 
+    /**
+     * @todo Remove definition and calls after upgrade to PHP 7.4
+     *
+     * This can be removed once we update to 7.4 or above as then
+     * we can use php.ini directive to achieve the same `session.cookie_samesite=None`
+     */
+    public static function sameSiteCookieWorkaroundPrePhp74()
+    {
+        if (version_compare(PHP_VERSION, '7.3.0', '<')) {
+            setcookie('IFBYPHONE', self::getId(), 0, '/; SameSite=None; HttpOnly; Secure');
+        } else {
+            setcookie('IFBYPHONE', self::getId(), [
+                'expires'  => 0,
+                'path'     => '/',
+                'secure'   => true,
+                'httponly' => true,
+                'samesite' => 'None'
+            ]);
+        }
+    }
+
 }