michael's feedback #2

gfichtenholt · Sep 2, 2021 · 7e34733 · 7e34733
1 parent cb65c43
commit 7e34733
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/cmd/kubeapps-apis/plugins/fluxv2/packages/v1alpha1/release_test.go b/cmd/kubeapps-apis/plugins/fluxv2/packages/v1alpha1/release_test.go
@@ -19,6 +19,7 @@ import (
 	"io/ioutil"
 	"net/http"
 	"net/http/httptest"
+	"os"
 	"testing"
 
 	redismock "github.com/go-redis/redismock/v8"
@@ -643,7 +644,11 @@ func TestCreateInstalledPackage(t *testing.T) {
 	}
 
 	// currently needed for CreateInstalledPackage func
-	t.Setenv("POD_NAMESPACE", "kubeapps")
+	// TODO (gfichtenholt) replace below with t.Setenv("POD_NAMESPACE", "kubeapps") when we switch to go 1.17
+	// to avoid compile error "t.Setenv undefined (type *"testing".T has no field or method Setenv)"
+	origVal := os.Getenv("POD_NAMESPACE")
+	os.Setenv("POD_NAMESPACE", "kubeapps")
+	t.Cleanup(func() { os.Setenv("POD_NAMESPACE", origVal) })
 
 	for _, tc := range testCases {
 		t.Run(tc.name, func(t *testing.T) {