Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AssertHelper excluded from code coverage #69

Merged
merged 2 commits into from
Mar 26, 2019
Merged

AssertHelper excluded from code coverage #69

merged 2 commits into from
Mar 26, 2019

Conversation

gfoidl
Copy link
Owner

@gfoidl gfoidl commented Mar 26, 2019

It is only used for Debug, so the coverage results are not correct, as coverage is only done in Release (cf. #29).

It is only used for Debug, so the coverage results are not correct.
@gfoidl gfoidl self-assigned this Mar 26, 2019
@codecov-io
Copy link

codecov-io commented Mar 26, 2019

Codecov Report

Merging #69 into master will increase coverage by 0.89%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #69      +/-   ##
========================================
+ Coverage    99.1%   100%   +0.89%     
========================================
  Files          27     26       -1     
  Lines        3121   3093      -28     
========================================
  Hits         3093   3093              
+ Misses         28      0      -28
Impacted Files Coverage Δ
source/gfoidl.Base64/Internal/AssertHelper.cs

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ddf0e2...ec7c4cf. Read the comment docs.

.codecov.yml Outdated Show resolved Hide resolved
@gfoidl
Copy link
Owner Author

gfoidl commented Mar 26, 2019

Need to wait for #68, so that CI is happy.

@gfoidl gfoidl merged commit 8c5d5c7 into master Mar 26, 2019
@gfoidl gfoidl deleted the codecov branch March 26, 2019 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants