Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix colon-space hashes #22

Closed
wants to merge 1 commit into from
Closed

Conversation

joaquincasares
Copy link
Contributor

I do understand that I can pass in my own function, but figured this might be nice to have support out of the box for cases like this:

https://website.com/article/1234.html#chapter-1-something-to-talk-about

vs.

https://website.com/article/1234.html#chapter-1:-something-to-talk-about

while still allowing other cases like:

https://website.com/article/1234.html#chapter-1-http://-examples

@gfranko
Copy link
Owner

gfranko commented Apr 5, 2013

@joaquincasares This looks like a great addition. Would you mind sending this PR to the dev branch? I will be releasing a new version soon. Thanks!

@joaquincasares
Copy link
Contributor Author

Sure thing! I'll be waiting for it.

Btw, nice job on the project! Thanks!

@ghost ghost assigned gfranko Apr 14, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants